Windows: Use schannel for curl #65
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to the SSL certificate issues we identified back in #55 and further elaborated on in congruity/congruity#12 (comment) . This is what I was referring to in #57 (comment) (though is independent of the wheel changes etc.)
We found that if we used schannel on Windows for curl, connections to the Logitech site would automatically pull down the appropriate SSL certificates into the certificate store and use them. The prior method discussed in #56 would use the SSL certificates from the store but wouldn't install them if they were missing.
This PR provides two items:
Known improvements that could be made: