C20048 multi version repair guardrail trunk #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for auto-repair
…yspace is provided in args
…t::testConversionsInverses
…EP_IF_REPAIR_FINISHES_QUICKLY
… Tests run: 15, Failures: 7
…dra_20047 Merge CASSANDRA-20047 & CASSANDRA-20043 to trunk_cep_37
…ndra_20101_1 Ignore repair for system_traces keyspace
…mpatabilityTest trunk: Fix broken JMXCompatabilityTest due to Preview Repair
…ndra_20160 Auto-repair scheduler should be rate-limited
tolbertam
reviewed
Jan 7, 2025
| logger.debug("Auto-repair is disabled for repair type {}", repairType); | ||
| return; | ||
| } | ||
| if (!Guardrails.mixedRepairsEnabled.isEnabled(null)) |
There was a problem hiding this comment.
Could just use enabled() instead right?
Author
There was a problem hiding this comment.
enabled() is if the guardrail is turned on or off, not if its predicate is true
| } | ||
| if (!Guardrails.mixedRepairsEnabled.isEnabled(null)) | ||
| { | ||
| logger.debug("Cannot run repair when nodes in the cluster have different versions."); |
Owner
There was a problem hiding this comment.
Could we use a NoSpamLogger to log it as Info every 5 minutes? The reason is without any logging or metrics; it would become difficult for admins to diagnose why the repair has not been running. A new metric here would also provide visibility.
jaydeepkumar1984
force-pushed
the
trunk_cep_37
branch
from
95d0a5e to
e093b34
Compare
jaydeepkumar1984
force-pushed
the
trunk_cep_37
branch
from
0c0f607 to
cf60b85
Compare
jaydeepkumar1984
force-pushed
the
trunk_cep_37
branch
from
9feb931 to
89b4ab6
Compare
jaydeepkumar1984
pushed a commit
that referenced
this pull request
Jan 28, 2026
…s altered/created (CASSANDRA-20570) (#21) ## Summary patch by Nikhil Kumawat, Nikhil; reviewed by David Capwell, guo Maxwell for CASSANDRA-20570 ## Test Plan ## Jira Issues T3-CAAS-799 Co-authored-by: Nikhil Kumawat <nikhilkumawat03@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira