Code Review

Code Review Script

Purpose: Improve code understanding in our team and code readiness. Find as much as possible bug defects.

Steps

0. All members read and understand code beforehand.
1. Describe agenda of the meeting.
2. Authors of code describe what have his/her do, what's going on for each part of code.
3. Other members review issues that they have found. One member record the issues, what function is a trouble.(Optional) Suggest the way to solve the issues. And Inform to all members.
4. Assign the authors of code to fix the issues.
5. Follow up the issues and approve vias Pull request.

Code Review Checklist

• Code is working.
• Readable/Easy to understand.
• Don't Repeat Yourself.
• Write comments if code is hard too understand
• One function do one thing.
• Descriptive name.

Summary

We were doing code review by the feature on 3rd Nov 2022. All members were participated. From 4.10 PM until 4.40 PM

1. Navigation bar.

Issue(s)

• Can't search the exact name using search bar on navigation bar.
• Search preview exceed the height of the screen.
• Dropdown menus exceed the height of the screen.

2. Menu models

Issue(s)

Duplicated objects in the database.

3. Menu detail page

Issues

• Unit of ingredients in menu detail page not shown.
• Can not reach detail page if user is not authenticated.

4. Index page

Issue(s)

Menu that have no picture was shown on Menu for You.

5. Suggest food of the day

Issue(s)

Food of the day won't change as it should.

Suggestion

Possible cause may be

1.) Admin didn't change the menu of the day.
2.) Machine receive the old caches.
3.) code on rating score is affect to menu detail page.