Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the
PACKAGE_NAMEenvironment variable is set and improves workflow conditional logic for GitHub Actions. Instead of hardcoding or settingPACKAGE_NAMEin workflow files, a new reusable action is introduced to derive it automatically from the repository name. Additionally, all workflow and action files update their conditionals to usegithub.event.repository.namefor better reliability and portability.Key improvements include:
Environment Variable Management
set-package-name(.github/actions/setup/set-package-name/action.yml) that sets thePACKAGE_NAMEenvironment variable by replacing hyphens with underscores in the repository name, making this process reusable and less error-prone.build.yml,ci.yml) to use the newset-package-nameaction instead of hardcodedenvvalues, and documented its usage indocs/WORKFLOWS.md. [1] [2] [3] [4] [5] [6]Conditional Logic Improvements
github.event.repository.namefor conditional steps, replacing the previousgithub.repositorychecks, which improves compatibility for forks and external repositories. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Documentation Updates
docs/WORKFLOWS.mdto reflect the new way of settingPACKAGE_NAME, including example usage for the new action and removing outdated environment variable instructions. [1] [2] [3] [4]These changes make the workflows more maintainable, reusable, and robust for different repository contexts.