Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the workflow scripts and related documentation to improve consistency and clarity in version and name extraction from
pyproject.tomlanduv.lock. The main changes include renaming script entrypoints for clarity, adding new functionality to extract the project name, updating the workflow logic and documentation, and extending the test suite to cover these updates.Workflow and script refactoring:
pyproject.tomlfor extracting version and name to use a consistent naming scheme (ci-pyproject-version,ci-pyproject-name,ci-uv-lock-version) and added a new entrypoint for extracting the project name.Functionality improvements:
_get_name_pyprojectandprint_name_pyprojectfunctions intemplate_python/workflows.pyto extract and print the project name frompyproject.toml, and updated_get_version_uv_lockto use the new name extraction method for improved reliability. [1] [2]Workflow logic and documentation updates:
.github/actions/ci/version-check/action.ymland its documentation indocs/WORKFLOWS.mdto use the new script names for extracting version information. [1] [2]Testing enhancements:
tests/test_workflows.pyto cover the new name extraction functionality and ensure that the workflow logic is properly validated. [1] [2] [3]