Conversation
There exist test cases run by `ModulePluginSmokeTest` that are always excluded due to the minimum JDK version now being 17 and the minimum Gradle version now being 8.11. Removing these test cases allows some clean-up to be done without reducing the test coverage: - `test-project-kotlin-pre-1-7` project can be removed, as this version of Kotlin does work with Gradle versions > 8.0 - `smokeTestJunit5` no longer needs tests covering older versions of Junit (< 5.8.0), as these require Gradlew versions < 8.11 Also added the latest 5.+ JUnit version to the tests and docs
big-andy-coates
added
the
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There exist test cases run by
ModulePluginSmokeTestthat are always excluded due to the minimum JDK version now being 17 and the minimum Gradle version now being 8.11.Removing these test cases allows some clean-up to be done without reducing the test coverage:
test-project-kotlin-pre-1-7project can be removed, as this version of Kotlin does work with Gradle versions > 8.0smokeTestJunit5no longer needs tests covering older versions of Junit (< 5.8.0), as these require Gradlew versions < 8.11Also added the latest 5.+ JUnit version to the tests and docs