Issue 81 create client personal data service#100
Open
ChirkinaTanya wants to merge 5 commits intodevelopfrom
Open
Issue 81 create client personal data service#100ChirkinaTanya wants to merge 5 commits intodevelopfrom
ChirkinaTanya wants to merge 5 commits intodevelopfrom
Conversation
…the PersonalDataServiceImpl
…aoImpl, created passportChange and dataChangeUserData methods in PersonalDataServiceImpl
…ivingLicense and updateDrivingLicense methods, added validateDrivingLicense method
a-deriabin
reviewed
Mar 2, 2020
| private DrivingLicenseDao drivingLicenseDao; | ||
| private PasswordHashService passwordHashService; | ||
|
|
||
| public PersonalDataServiceImpl(UsersDao usersDao, PassportDao passportDao, PasswordHashService passwordHashService){ |
a-deriabin
reviewed
Mar 2, 2020
| } | ||
|
|
||
|
|
||
| } |
Collaborator
There was a problem hiding this comment.
long lines and too many empty lines
a-deriabin
reviewed
Mar 2, 2020
| UsersEntity usersEntity = usersDao.get(userId); | ||
| PassportEntity passportEntity = passportDao.get(usersEntity.getPassId()); | ||
| if (usersEntity == null){ | ||
| throw new RuntimeException(); |
Collaborator
There was a problem hiding this comment.
Would be good to write some kind of message
a-deriabin
approved these changes
Mar 2, 2020
nikaalin
approved these changes
Mar 2, 2020
PavelEzhkov
reviewed
Mar 3, 2020
Collaborator
PavelEzhkov
left a comment
PavelEzhkov
left a comment
There was a problem hiding this comment.
Please resolve all comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.