Split and union #48
Draft
Split and union #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jaspervdj The biggest question for me is how to benchmark this. I don't understand the benchmark suite of this package; can you give me some guidance? |
treeowl
force-pushed
the
split-union
branch
3 times, most recently
from
8ca65dd to
44de944
Compare
Start work on adding set/map-like functions. Currently, `split`, `splitMaybe`, and `union`.
Owner
|
@treeowl It's been some years since I looked at that myself! It looks like this is really a benchmark suite to compare different implementations, not really to look for regressions and speedups for the same implementation. That means we can't easily benchmark things like |
Contributor
Author
|
That sounds reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start work on adding set/map-like functions. Currently,
split,splitMaybe, andunion.