Open
Conversation
- Replace help files with inline info fields on all QML controls - Standardize table/plot/container titles to Title Case - Wrap missing strings in gettext() for i18n - Fix initCollapsed placement in PLS-SEM correlation containers - Fix "Residuals" → "Residual" in covariance matrix titles - Enable preloadData for all analyses Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
juliuspfadt
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 61.67% 70.41% +8.73%
==========================================
Files 13 13
Lines 6437 6537 +100
==========================================
+ Hits 3970 4603 +633
+ Misses 2467 1934 -533 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- MIMIC: add additionalFitMeasures, rSquared, pathPlot, syntax tests - MediationAnalysis: add rSquared, pathPlot, syntax tests - LGCM: add quadratic growth, additionalFit, rSquared, impliedCov, residualCov, syntax, curvePlot, pathPlot tests - SEM: add equality constraints (loading, intercept, regression, latent covariance) multigroup tests - PLSSEM: add endogenous indicator prediction test - MNLFA: add configural invariance, loadings, factor variance/means/ covariances, fit-per-group tests - Remove empty R/moderation.R Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the SEM module by replacing separate help files with inline tooltips, standardizing UI text formatting, and improving internationalization support.
Changes:
- Replaced markdown help files with inline
infofields on all QML controls across SEM, Mediation Analysis, MIMIC, PLS-SEM, and MNLFA analyses - Standardized all table, plot, and container titles to Title Case (e.g., "Model fit" → "Model Fit", "Std. error" → "Std. Error")
- Wrapped previously unwrapped user-visible strings in
gettext()for proper internationalization - Fixed
initCollapsedparameter placement in PLS-SEM correlation containers - Enabled
preloadDataat module level for all analyses - Fixed inconsistent naming: "Residuals covariance matrix" → "Residual Covariance Matrix"
Reviewed changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inst/qml/SEM.qml | Added comprehensive info fields to all controls; removed HelpButton for estimators |
| inst/qml/PLSSEM.qml | Added info fields throughout the interface |
| inst/qml/ModeratedNonLinearFactorAnalysis.qml | Added info fields for factor analysis controls |
| inst/qml/Mimic.qml | Added info fields to MIMIC model controls |
| inst/qml/MediationAnalysis.qml | Added info fields for mediation analysis options |
| R/sem.R | Standardized 20+ table/container titles to Title Case with gettext() |
| R/plssem.R | Fixed title spacing, standardized titles, fixed initCollapsed placement |
| R/mimic.R | Standardized titles to Title Case |
| R/mediationanalysis.R | Standardized titles and wrapped strings in gettext() |
| R/lgcm.R | Standardized titles throughout latent growth curve functions |
| R/common.R | Standardized fit table title |
| inst/Description.qml | Enabled preloadData for entire module; removed redundant per-analysis settings |
| inst/help/*.md | Deleted 7 help markdown files replaced by inline info |
| tests/testthat/*.R | Updated test expectations for numerical changes (likely R package updates) |
| NEWS.md | Documented all changes |
| .gitignore | Added AI assistant config patterns and test problem files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infofields on all QML controls across SEM, Mediation Analysis, MIMIC, PLS-SEM, and MNLFAgettext()for internationalizationinitCollapsedparameter placement in PLS-SEM correlation containerspreloadDatafor all analyses