Open
Conversation
hrgodmann
approved these changes
Jan 13, 2026
There was a problem hiding this comment.
I'll split between Code and JASP comments.
Code (minor) Comments:
- In the R code, in function .bpcsSamplePosteriorOrPrior , is the MCMC settings supposed to be hardcoded?
- In Description.qml, should it be Gauge r&R Study really or actually Gauge R&R Study?
- In the priors qml, should the console.log functions stay in?
JASP comments:
- specifying a higher "lower specification limit" than the "higher specification limit" just transforms the lower into a negative number, I assume this is not desired behaviour.
- When I run the analysis, then change lower and upper specification limit, the Capability table doesn't update, also the plots "Posterior Distribution" dont update.
- When in the "Prior and Posterior" inference section the "Posterior distribution" plot is chose, and then the Layout 'All metrics in one plot" is selected, additionally printing "point estimates" and "CI" in the plot makes it unreadable even when widened because the values seem randomly distributed across the plot.
- I think plotting the priors looks a bit strange because the x axis is so wide, thus the distribution is not really identifiable by eye anymore. this means that the central CI plotting function for the prior basically does nothing for Cp CpU and CpL. If "identical across pane" is chosen for the axes, it makes it even worse
- sequential plots are awesome!!
- do the MCMC settings do anything yet, as they are still hard coded in the code I believe
- the "posterior predictive distribution" plot shows wide samples as a histogram but very narrow CI when chosen, is this correct?
|
I spotted some things when working with the sequential analysis:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.