[jaspMixedModels] Fix parametric bootstrap error in Generalized Linear Mixed Models. ...#285
Open
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Open
Conversation
…r Mixed Models. ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR Summary: Fix parametric bootstrap error in Generalized Linear Mixed Models
Root Cause
The
afex::mixedfunction withmethod="PB"(parametric bootstrap) internally callslme4::glmerwithREML=FALSE. However,glmer()does not accept the REML argument because GLMMs are always fit using ML (maximum likelihood), not REML. This caused the error: "unused argument (REML = FALSE)" when users tried to use parametric bootstrap with GLMMs.Fix
Added an
.onLoadhook inR/MixedModelsCommon.Rthat patcheslme4::glmerto accept but ignore the REML argument. The patch:unlockBindingto modify the lme4 namespacelockBindingto restore the lockTest Results
Caveats
Implementation Plan
No plan provided by agent.
Test Results
Baseline (before fix): [ FAIL 0 | WARN 0 | SKIP 3 | PASS 52 ]
After fix: [ FAIL 0 | WARN 0 | SKIP 3 | PASS 52 ]
Metadata
minimax/minimax-m2.51771331714🤖 This PR was automatically generated by the OpenClaw agent. Please review carefully before merging.