Add optimizer control settings for classical LMM and GLMM#253
Draft
Add optimizer control settings for classical LMM and GLMM#253
Conversation
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Allow optimizer control settings for classical LMM and GLMM
Add optimizer control settings for classical LMM and GLMM
Sep 10, 2025
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
Author
Done! I've extracted the optimizer settings into a new common QML component called |
FBartos
requested changes
Sep 10, 2025
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
Collaborator
|
so, this turned to be much more complicated than expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optimizer control settings to the classical Linear Mixed Models (LMM) and Generalized Linear Mixed Models (GLMM) modules, allowing users to adjust optimizer parameters when models fail to converge.
Changes Made
UI Enhancements
Code Organization
Advanced.qmlcomponent in the common folder containing optimizer settingsBackend Implementation
.mmCreateOptimizerControl()function to handle optimizer-specific parameters according to each optimizer's documentation.mixedInterceptML()for intercept-only modelsafex::mixed()calls for full modelslmer/glmerfunctions viaoptCtrlparameterError Message Improvements
Testing
Scope
This enhancement is only available for classical models (LMM and GLMM). Bayesian models continue to use their existing MCMC control settings and are unaffected by these changes.
Motivation
Complex mixed models often encounter convergence issues that can be resolved by adjusting optimizer settings. This was previously impossible in JASP, forcing users to abandon analyses or switch to other tools. These new controls provide the flexibility needed to handle challenging models while maintaining JASP's user-friendly interface.
Fixes #252.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.