[jaspLearnStats] Fix issue #3107 (second issue - plot sizing): Increase the default...#150
Open
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Open
Conversation
…se the default...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/3107
Summary: Fix Issue #3107 - Mosaic Plot Sizing
What was wrong
The mosaic plots in the Effect Sizes analysis (phi effect size) were using a default width that was too small. The plots were created without an explicit
widthparameter, resulting in a default width derived fromheight * aspectRatio(500 * 1 = 500).What was changed
Modified
/workspace/R/LSeffectSizes.Rin the.tsPhiPlotfunction to add explicitwidth = 650to threecreateJaspPlotcalls:phiCombinedPlot- combined population and simulation plotphiPopulationPlot- population distribution plotphiSimulationPlot- simulation distribution plotThe new width of 650 represents a 30% increase from the previous default of 500 (500 * 1.3 = 650).
Verification
Implementation Plan
Plan: Increase default width of mosaic plots by 30%
Root Cause
The phi effect size plots (mosaic plots) in
/workspace/R/LSeffectSizes.Rare created without specifying an explicitwidthparameter. Currently they use:height = 500aspectRatio = 1This results in a default width of ~500 (height * aspectRatio). The issue requests increasing this by 30%, so the new width should be 650.
Location
File:
/workspace/R/LSeffectSizes.RFunction:
.tsPhiPlot(lines 1022-1072)Changes Needed
Add
width = 650to threecreateJaspPlotcalls:phiCombinedPlot- combined population and simulation plotphiPopulationPlot- population distribution plotphiSimulationPlot- simulation distribution plotAll currently have
height = 500, aspectRatio = 1. Addingwidth = 650increases width by 30% (500 → 650).Test Impact
Test Results