[jaspLearnStats] Change default value of delta to 0.5 in Effect Sizes within Learn S...#149
Closed
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Closed
Conversation
… within Learn S...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: https://github.com/jasp-stats/INTERNAL-jasp/issues/3107
Summary
Issue: Change default value of delta to 0.5 in Effect Sizes within Learn Stats module.
Root Cause: The QML file
inst/qml/LSeffectSizes.qmlhad the default value for Cohen's delta set to0instead of a more useful value like0.5.Changes Made:
inst/qml/LSeffectSizes.qmlline 65: ChangeddefaultValue: 0todefaultValue: 0.5for theeffectSizeValueDeltaDoubleField.Test Status:
Implementation Plan
No plan provided by agent.
Test Results