[jaspLearnStats] Change the default value of delta from 0 to 0.5 in Learn Stats -> E...#146
Closed
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Closed
Conversation
…earn Stats -> E...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR Summary: Change Default Delta Value in Learn Stats Effect Sizes
Root Cause
The default value for delta (Cohen's δ) in the Learn Stats → Effect sizes analysis was set to 0. When delta is 0, the two distributions (control and experimental) overlap exactly, making the visualization uninformative and unclear for learning purposes.
What Was Changed
inst/qml/LSeffectSizes.qmldefaultValue: 0todefaultValue: 0.5for theeffectSizeValueDeltaoptionWhy This Fix Makes Sense
Setting delta to 0.5 by default provides a more informative visualization:
Caveats / Things to Check
Implementation Plan
No plan provided by agent.
Test Results
Baseline (before fix): Could not parse test summary
After fix: No tests exist in this module (tests/testthat/ directory is empty).
The change has been verified manually - defaultValue changed from 0 to 0.5 in inst/qml/LSeffectSizes.qml:65
Agent Stats
Turns: 25 | Cost: $1.54 | Duration: 8.2min
Log files
/home/openclaw/logs/module-developer-jaspLearnStats_1771797321.claude.jsonl/home/openclaw/logs/module-developer-jaspLearnStats_1771797321.verbose.log/home/openclaw/logs/module-developer-jaspLearnStats_1771797321.log