Skip to content

Comments

Fix tests#208

Open
FBartos wants to merge 3 commits intomasterfrom
fix-tests
Open

Fix tests#208
FBartos wants to merge 3 commits intomasterfrom
fix-tests

Conversation

@FBartos
Copy link

@FBartos FBartos commented Jan 30, 2026

requires: jasp-stats/jaspTools#68

ANOVA/ANCOVA still unavailbe since we would need to enable dangerous encoding in jaspTools

Copilot AI review requested due to automatic review settings January 30, 2026 10:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes tests to work with the updated jaspTools package and corrects a spelling error in error messages.

Changes:

  • Fixed spelling error "Contraints" → "Constraints" in error message across R code and all translation files
  • Updated test files to use new forceEncode parameter for proper encoding of model and hypothesis options
  • Replaced basic error checks with comprehensive test assertions including table comparisons and plot validations

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/testthat/test-example-bainSem.R Added full test assertions with expected table values and plot checks, replaced basic error checking
tests/testthat/test-example-bainRegression.R New test file with comprehensive assertions for regression analysis
tests/testthat/test-example-bainPairedSamples.R Updated to use forceEncode parameter and minor numeric precision updates
tests/testthat/test-example-bainOneSample.R Updated to use forceEncode parameter and minor numeric precision updates
tests/testthat/test-example-bainIndependentSamples.R Updated to use forceEncode parameter and minor numeric precision update
tests/testthat/test-example-bainAnova.R New test file, currently skipped due to jaspTools limitations
tests/testthat/test-example-bainAncova.R New test file, currently skipped due to jaspTools limitations
R/bainCommon.R Fixed spelling: "Contraints" → "Constraints" in error message
po/*.po files Propagated spelling fix to all translation files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FBartos FBartos requested a review from koenderks February 2, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant