Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes tests to work with the updated jaspTools package and corrects a spelling error in error messages.
Changes:
- Fixed spelling error "Contraints" → "Constraints" in error message across R code and all translation files
- Updated test files to use new
forceEncodeparameter for proper encoding of model and hypothesis options - Replaced basic error checks with comprehensive test assertions including table comparisons and plot validations
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-example-bainSem.R | Added full test assertions with expected table values and plot checks, replaced basic error checking |
| tests/testthat/test-example-bainRegression.R | New test file with comprehensive assertions for regression analysis |
| tests/testthat/test-example-bainPairedSamples.R | Updated to use forceEncode parameter and minor numeric precision updates |
| tests/testthat/test-example-bainOneSample.R | Updated to use forceEncode parameter and minor numeric precision updates |
| tests/testthat/test-example-bainIndependentSamples.R | Updated to use forceEncode parameter and minor numeric precision update |
| tests/testthat/test-example-bainAnova.R | New test file, currently skipped due to jaspTools limitations |
| tests/testthat/test-example-bainAncova.R | New test file, currently skipped due to jaspTools limitations |
| R/bainCommon.R | Fixed spelling: "Contraints" → "Constraints" in error message |
| po/*.po files | Propagated spelling fix to all translation files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires: jasp-stats/jaspTools#68
ANOVA/ANCOVA still unavailbe since we would need to enable dangerous encoding in jaspTools