Skip docker push for non-tagged builds and upgrade checkout to v6 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only push containers to GHCR when building from a tag, avoiding permission errors on Dependabot and regular branch builds.
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on f59b6de..0a6979b
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• .github/workflows/dockerpush.yml
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
High-level PR Summary
This PR modifies the Docker push workflow to only push containers to the GitHub Container Registry when building from tagged releases, preventing permission errors on Dependabot and regular branch builds. Additionally, it upgrades the
actions/checkoutaction from v4 to v6.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
.github/workflows/dockerpush.ymlSummary by cubic
Push to GHCR only on tagged builds to prevent permission errors on Dependabot and branch builds. Also upgrade actions/checkout from v4 to v6.
Written for commit 0a6979b. Summary will update automatically on new commits.