Fix CI submodule checkout and set Dependabot to weekly #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the CI build failure by properly checking out submodules with recursive mode and full depth, ensuring yaml-cpp headers are available. Also changes Dependabot to run weekly instead of daily as requested.
Version 5.2.0 is missing the smi-nerd JAR file from the release assets. Downgrading to 5.1.3 which includes all required files: - smi-nerd-v5.1.3.jar - ctpanonymiser-v5.1.3.zip - smi-services-v5.1.3-linux-x64.tgz
Replace hardcoded version directories (v4.0.0 and v3.0.2) with the SMIV variable to ensure version consistency throughout the build. Changes: - Line 17: smi-services-v4.0.0-linux-x64 → smi-services-v$(SMIV)-linux-x64 - Line 77: smi-services-v3.0.2-linux-x64 → smi-services-v$(SMIV)-linux-x64
Changes curl -L to curl -sL on line 66 to avoid flooding CI logs with progress bar output.
Changes semicolons to && so that tar commands will not execute if cd fails, preventing confusing error messages and ensuring the build fails cleanly when directories don't exist.
Updates base image from adoptopenjdk/openjdk11:debian-jre to eclipse-temurin:11-jre to fix Debian Buster EOL repository errors. Eclipse Temurin is the official successor to AdoptOpenJDK and uses a supported Debian/Ubuntu base, avoiding 404 errors from obsolete Debian Buster repositories.
- Add -q flag to all wget commands (lines 86, 89, 95, 98) to suppress progress bar output that floods CI logs - Update libicu63 to libicu72 for compatibility with Eclipse Temurin base image which uses newer Debian/Ubuntu - Add -y flag to apt-get install to avoid interactive prompts
Replace libicu72 with libicu-dev which is version-agnostic and will install the appropriate libicu version for whatever Debian/Ubuntu release the base image uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
.github/workflows/dockerpush.ymlto usesubmodules: recursiveandfetch-depth: 0to ensure yaml-cpp headers are available during build.github/dependabot.ymlto check for updates weekly instead of dailyTest plan