Allow for loading raw ROM dumps #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a bonus feature, also report the error code when loading an object
jarikomppa
reviewed
Aug 27, 2018
| if (!f) return -1; | ||
|
|
||
| int address = 0; | ||
| while (!feof(f)) |
Owner
There was a problem hiding this comment.
This loop will happily try to write megabytes of stuff into memory.. it would probably be a good idea to limit read to the actual target buffer size.
jarikomppa
requested changes
Aug 27, 2018
| FILE *f; | ||
| if (aFilename == 0 || aFilename[0] == 0) | ||
| return -1; | ||
| f = fopen(aFilename, "r"); |
Owner
There was a problem hiding this comment.
Please use mode "rb" instead of "r", otherwise windows targets will just load garbage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a bonus feature, also report the error code when loading an object