Skip to content

redis - chore: upgrading redis to 5.11.0#172

Merged
jaredwray merged 1 commit intomainfrom
redis---chore-upgrading-redis-to-5.11.0
Mar 8, 2026
Merged

redis - chore: upgrading redis to 5.11.0#172
jaredwray merged 1 commit intomainfrom
redis---chore-upgrading-redis-to-5.11.0

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Mar 8, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
redis - chore: upgrading redis to 5.11.0

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine dependency upgrade, specifically updating the Redis client library to its latest version, 5.11.0. This ensures the project benefits from the most recent features, performance improvements, and bug fixes provided by the Redis client, maintaining compatibility and leveraging modern capabilities. The changes are primarily confined to package manifest and lock files.

Highlights

  • Redis Dependency Upgrade: The core redis dependency has been upgraded from version 5.10.0 to 5.11.0 in the packages/redis/package.json file.
  • Lockfile Updates: The pnpm-lock.yaml file has been updated to reflect the new redis version and its associated client packages (@redis/bloom, @redis/client, @redis/json, @redis/search, @redis/time-series).
  • New Peer Dependency: The @redis/client package now includes @node-rs/xxhash as an optional peer dependency, which is also reflected in the pnpm-lock.yaml.
Changelog
  • packages/redis/package.json
    • Updated the redis dependency from ^5.10.0 to ^5.11.0.
  • pnpm-lock.yaml
    • Updated the redis package version and specifier to 5.11.0.
    • Updated versions for @redis/bloom, @redis/client, @redis/json, @redis/search, and @redis/time-series to 5.11.0.
    • Added @node-rs/xxhash as an optional peer dependency for @redis/client.
    • Included @node-rs/xxhash in the transitivePeerDependencies for the redis package.
Activity
  • The pull request description includes standard checks for contributing guidelines and test coverage, indicating initial setup.
  • No specific human activity (comments, reviews, or progress updates) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (64f8900) to head (798b5c3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1067      1067           
  Branches       215       216    +1     
=========================================
  Hits          1067      1067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the redis dependency from ^5.10.0 to ^5.11.0. This is a minor version update, and the lockfile has been updated accordingly. The change is straightforward and appears correct. My review includes a suggestion to improve dependency declaration clarity for a new optional peer dependency introduced by this upgrade.

Comment on lines +567 to +571
peerDependencies:
'@node-rs/xxhash': ^1.1.0
peerDependenciesMeta:
'@node-rs/xxhash':
optional: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The upgrade to redis@5.11.0 introduces @node-rs/xxhash as a new optional peer dependency for @redis/client. While pnpm correctly handles this, for better project clarity and maintainability, it would be beneficial to also declare @node-rs/xxhash as an optionalDependency in packages/redis/package.json. This makes the dependency explicit to developers and helps ensure consistent behavior across different environments or package managers, which is particularly important for native addons.

@jaredwray jaredwray merged commit b8f1b6c into main Mar 8, 2026
9 checks passed
@jaredwray jaredwray deleted the redis---chore-upgrading-redis-to-5.11.0 branch March 8, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant