Skip to content

feat: updating to use HookEntry as core #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredwray merged 1 commit into from
Jan 5, 2026
+13 −14
Merged

feat: updating to use HookEntry as core #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,25 +169,25 @@ export class Hookified extends Eventified {
* @returns {void}
*/
public onHook(event: string, handler: Hook) {
this.validateHookName(event);
if (!this.checkDeprecatedHook(event)) {
return; // Skip registration if deprecated hooks are not allowed
}
const eventHandlers = this._hooks.get(event);
if (eventHandlers) {
eventHandlers.push(handler);
} else {
this._hooks.set(event, [handler]);
}
this.onHookEntry({ event, handler });
}

/**
* Adds a handler function for a specific event that runs before all other handlers
* Adds a handler function for a specific event
* @param {HookEntry} hookEntry
* @returns {void}
*/
public onHookEntry(hookEntry: HookEntry) {
this.onHook(hookEntry.event, hookEntry.handler);
this.validateHookName(hookEntry.event);
if (!this.checkDeprecatedHook(hookEntry.event)) {
return; // Skip registration if deprecated hooks are not allowed
}
const eventHandlers = this._hooks.get(hookEntry.event);
if (eventHandlers) {
eventHandlers.push(hookEntry.handler);
} else {
this._hooks.set(hookEntry.event, [hookEntry.handler]);
}
}

/**
Expand All @@ -197,8 +197,7 @@ export class Hookified extends Eventified {
* @returns {void}
*/
public addHook(event: string, handler: Hook) {
// Alias for onHook
this.onHook(event, handler);
this.onHookEntry({ event, handler });
}

/**
Expand Down
Loading