Skip to content

Clean up email template CSS and remove inline styles #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaredpalmer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up email template CSS and remove inline styles #247

jaredpalmer wants to merge 1 commit into from

Conversation

@jaredpalmer
Copy link
Owner

@jaredpalmer jaredpalmer commented Aug 22, 2025

Summary

  • Removed inline styles from email templates and replaced them with CSS classes
  • Improved code maintainability by separating styling concerns from HTML markup
  • Verified that juice properly inlines all CSS styles for email client compatibility

Changes Made

new-template.ts

  • Replaced inline styles on story elements with CSS classes (story-container, story-cell, story-title, story-title-link, story-description, story-meta, story-readmore)
  • Replaced inline styles on markdown/HTML containers with CSS classes
  • Replaced inline styles on wrapper elements with CSS classes (wrapper, wrapper-cell, header-cell, content-cell)

old-template.ts

  • Added story-wrapper div with CSS class for better structure
  • Added html-content wrapper for HTML elements
  • Moved element spacing to CSS classes

Test Plan

  • Verified development server runs without errors
  • Tested email generation with new template via /api/premail endpoint
  • Tested email generation with old template via /api/premail endpoint
  • Confirmed juice properly inlines CSS styles in generated HTML
  • Verified HTML output maintains proper email client compatibility

🤖 Generated with Claude Code

@jaredpalmer @claude
Clean up email template CSS and remove inline styles
48f9d28 
- Replaced inline styles with CSS classes in new-template.ts
- Replaced inline styles with CSS classes in old-template.ts
- Added structured CSS classes for story elements, containers, and wrappers
- Verified juice properly inlines all CSS styles for email compatibility
- Improved code maintainability by separating styling from markup

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@jaredpalmer jaredpalmer temporarily deployed to spmail-cleanup-email-te-m4mkns August 22, 2025 19:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaredpalmer