-
Notifications
You must be signed in to change notification settings - Fork 97
feat: support max-* screen prefix variants
#380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: support max-* screen prefix variants
#380
Conversation
|
I have a slight hesitation about adding these without supporting the combined use case of |
|
Adding range support will complicate the logic a bit, since we would need to cache prefixes locally, but it should be not that difficult. When it comes to speed, is there any benchmark that we can run to compare the results with base code, and asses the impact of the changes?
Yup, it's just different approach, since by default Tailwind screen breakpoints setup is mobile-first, while |
|
@Simek appreciate all the contributions lately. can you tell me a little bit about what you're working on that is motivating all these changes, and a little more about who you are? |
|
Thanks! 🙏 All of the changes are motivated by this refactor effort of React Native Directory styling: I have chosen As for the part who am I - I'm the React Native Core contributor and community member for few years, helping Meta with different OSS projects and website, in Expo I was working mainly on EAS and helping other teams with UI/UX/DX. |
|
ok, thanks for the context, I appreciate it. back to this PR, i don't have a simple way to test for a performance regression i'm afraid. so, i guess we'd need to make a judgment call, i think i'm ok merging this, if it seems useful to you. i'm not doing any active RN development any more (though i have apps using this library still being maintained), so i'm a bit out of touch with the day to day realities of RN. |
Why
Tailwind automatically defines
max-*prefix variants of default or user-provided screen values:How
Add automatic support for stand alone
max-*screen prefix variants and related tests. Prefix ranges likexl:max-lg:*are not yet supported.