feat: support majority of filter style properties
#379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredh159
reviewed
Dec 29, 2025
| } | ||
|
|
||
| export function isArbitraryValue(value: string): boolean { | ||
| return value.startsWith(`[`) && value.endsWith(`]`); |
Owner
There was a problem hiding this comment.
do we not already have a function like this? or are there some obvious other places we should use it instead for clarity?
Contributor
Author
There was a problem hiding this comment.
Good point! I have extracted the helper from transforms resolver to avoid duplicating the code. After your comment I have found few more places where it can be used, replaced inline checks and made sure that all tests are still passing. Let me know if this approach make sense!
jaredh159
approved these changes
Dec 29, 2025
Owner
jaredh159
left a comment
jaredh159
left a comment
There was a problem hiding this comment.
seems good to me, just wonder about that helper function, see comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With the release of React Native 0.76 support for part of CSS filters has been added:
How
Implement majority of available filters (
brightness,contrast,saturate,grayscale,invert,sepiaandhue-rotate) using the array of object notation.Filters which left to do:
blur- should be the least complex one, besides supporting custom predefined values on Tailwind sidedropShadow- seems like an alternate approach to adding shadows to View, it seems to be based onboxShadowaded within the same release, and shares some some properties with it likeoffset*opacity- not sure what we should do about this one, since even Tailwind usesopacitydirectly, not via filters, and I'm not sure if the end-effect differs in any way than usingopacitystyle prop directlyRefs