Skip to content

Conversation

@John-Colvin
Copy link

@John-Colvin John-Colvin commented Jul 7, 2025

  1. Moved to new eslint flat config
  2. Moved to @react-native/babel-preset from metro-react-native-babel-preset as the former seemed to choke badly on the react-native flow source files in node_modules
  3. Removed scripts-prepend-node-path=true as it isn't supported in modern node
  4. Moved to @testing-library/react-native from the unsupported react-test-renderer
  5. Moved to '@stylistic/quotes' over the old typescript-eslint/quotes that is gone in recent versions.
  6. Fixes some linter errors (are you sure you wanted the backtick strings rule? It was in the original config)

What still needs doing:

  • A handful of remaining failing tests

I am finding myself a little out of my depth on them & was hoping for some original author help/guidance.

@jaredh159
Copy link
Owner

hey, appreciate the PR, and I might be up for providing some guidance, some or all of this seems like probably worth doing. however.... i'm just about to leave for a week long vacation, so i'm not going to be able to look at this carefully until early next week.

oh, and yes, i do want the strings backtick rule, just a personal preference thing.

@John-Colvin
Copy link
Author

hey, appreciate the PR, and I might be up for providing some guidance, some or all of this seems like probably worth doing. however.... i'm just about to leave for a week long vacation, so i'm not going to be able to look at this carefully until early next week.

No worries, I'm not in a rush. For me this was motivated by making some in-house changes to the lib and wanting confidence it works well with more recent react & react-native, at which point I just thought why not do the whole thing.

oh, and yes, i do want the strings backtick rule, just a personal preference thing.

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants