Skip to content

Update Windows.py correct delete password for username == None case #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChekKlient wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Update Windows.py correct delete password for username == None case #705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keyring/backends/Windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def delete_password(self, service, username):
deleted = False
for target in service, compound:
existing_pw = self._read_credential(target)
if existing_pw and existing_pw['UserName'] == username:
if existing_pw and (username == None or existing_pw['UserName'] == username):
deleted = True
self._delete_password(target)
if not deleted:
Expand Down