Remove unused dependency jeepney #704
Open
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeepney>=0.4.2 is listed as a dependency, but the README indicates that the jeepney backed was moved into a separate project. The dependency is not used directly any more either. Remove the unused dependency completely. See: https://gitlab.com/takluyver/keyring_jeepney
Collaborator
|
Okay, we depend on |
mitya57
approved these changes
Jan 2, 2025
Author
|
You're quite right. I was under the impression that it used |
Collaborator
|
SecretStorage used to use dbus-python, but in version 3.0.0 it was ported to Jeepney, which is much easier to install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jeepney>=0.4.2 is listed as a dependency, but the README indicates that the jeepney backed was moved into a separate project. The dependency is not used directly any more either.
Remove the unused dependency completely.
See: https://gitlab.com/takluyver/keyring_jeepney