[refactor] replace popular_smiles_dataset.py a csv file #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janumiko
changed the title
janumiko
force-pushed
the
janumiko/remove_popular_smiles
branch
3 times, most recently
from
e81bcdc to
f671fbf
Compare
janumiko
changed the title
janumiko
force-pushed
the
janumiko/remove_popular_smiles
branch
from
f671fbf to
45c68a0
Compare
Kowalski1024
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the super long python file with a single constant list with a loading of csv file stored in /data.
Add entries about data sources to readme.
Why
I think it's better to have this in a separate file in data than having a super long 16k line python file.
Tests