Skip to content

Conversation

@josev814
Copy link

adding a requirements txt file

josev814 added 2 commits May 28, 2020 18:05
should only be looking for the ip_address to update the client version for
@josev814
Copy link
Author

I tested this out today with the latest version of denyhosts, and it's working, so this should be good to merge in unless there's something else you want me to do.

I haven't included a report output yet. I'm looking at implementing d3 charts. https://observablehq.com/@d3/grouped-bar-chart So, rather than having matplotlib as a requirement and generating images, we can just do a query and pass json to the template of charts to generate.

@janpascal
Copy link
Owner

Hi Jose, thanks for your work. I think you forgot to include the changes to peering.py in the pull request, please add those, and also the unit tests.

josev814 added 3 commits May 29, 2020 11:59
resolving table name convention matching
updating views to get the latest information from the db and passing that
     information to the peering servers
@josev814
Copy link
Author

josev814 commented May 29, 2020

I made the suggested updates, and added in the missing peering code and unit tests.

The one issue I had is I wasn't able to get the unittests to run on my local environment. I keep getting a six.moves module doesn't exist even though six is installed. Trying to update the module seems to indicate that it's already up to date.

It would be nice if we could get the unittests moved over to travisci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants