-
Notifications
You must be signed in to change notification settings - Fork 6
adding ability to receive version report information from clients #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
adding requirements txt file
should only be looking for the ip_address to update the client version for
|
I tested this out today with the latest version of denyhosts, and it's working, so this should be good to merge in unless there's something else you want me to do. I haven't included a report output yet. I'm looking at implementing d3 charts. https://observablehq.com/@d3/grouped-bar-chart So, rather than having matplotlib as a requirement and generating images, we can just do a query and pass json to the template of charts to generate. |
|
Hi Jose, thanks for your work. I think you forgot to include the changes to peering.py in the pull request, please add those, and also the unit tests. |
resolving table name convention matching
adding ClientVersion test
updating views to get the latest information from the db and passing that
information to the peering servers
|
I made the suggested updates, and added in the missing peering code and unit tests. The one issue I had is I wasn't able to get the unittests to run on my local environment. I keep getting a six.moves module doesn't exist even though six is installed. Trying to update the module seems to indicate that it's already up to date. It would be nice if we could get the unittests moved over to travisci. |
adding a requirements txt file