Override Backbone.Model.clone correctly #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be in line with method being overriden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a mistake for a long time but it seems that older versions of Backbone have been more forgiving.
An older backbone where we were lucky it worked with backbone-couchdb.js: https://github.com/jashkenas/backbone/blob/0.9.2/backbone.js#L450
A recent backbone Backbone.Model.clone where we get weird results when using backbone-couchdb.js: https://github.com/jashkenas/backbone/blob/1.2.3/backbone.js#L707
The forgiveness happens in the constructor. Even if it used to work when used incorrectly, it definitely doesn't work now and this needs to be fixed.