Conversation
Partial fix for janko#93 This may not be the 'correct' fix, but it will not break any current users and is safe for immediate release
…BINARY (ASCII-8BIT)
Owner
|
Thanks for the heads-up. I think we can just call |
Contributor
Author
|
@janko yours is definitely the better solution. Note the similar problem in the httpx_test not covered by your change. |
Owner
|
Thanks, I missed it. That one doesn't appear Ruby 3.4-related, but just a newer version of HTTPX, I pushed an update now as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #93
Effectively, we're changing the text to match the output which on principle is not great. I think maybe matching the text of inspect is brittle and these tests need a re-think.
The text change on encoding I believe came from this change. So this does not pass on ruby 3.3.6, but does pass on 3.4.1 (not sure exactly which release that change came out in).