Handle 3xx redirects differently when streaming with Httpx #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently response status is checked for
3xxbeforeHTTPXhas a chance to follow redirects.Proposed fix removes
3xxstatuses from theresponse_error!method and instead proceeds with reading chunks.HTTPXdocumentation suggests skipping chunks while the redirects are followed. It doesn't raise an error if the maximum allowed number of redirects has been followed so we need to raiseDown::TooManyRedirectsif after reading all the chunks the status is still3xx.Proposed fix for this issue #101