Open
Conversation
Signed-off-by: Olivier Henley <olivier.henley@gmail.com>
|
Oh, this is an issue. The docs are correct for the new version, where we have renamed However, the version story is a problem as this now clashes with the old We are going to have to rethink something here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1
The actual does not build because https://opam.ocaml.org/packages/ppx_hardcaml/ indicates:
ppx_hardcaml version 1.3.0 (latest)
...
Published Sep 26, 2017
If we try anyway...
Now digging a bit on deps. we can see that https://opam.ocaml.org/packages/hardcaml_waveterm/
depends on ppx_deriving_hardcaml>=v0.16 & <v0.17
which fits with releases at https://github.com/janestreet/ppx_hardcaml ... which in turn is the true endpoint of
ppx_deriving_hardcamlhomepage.2
The presence of
$in the copied snippet is annoying at paste in cmd