An issue with viewing a model containing surfaces without coords attribute has been fixed#251
Open
samuelduchesne wants to merge 3 commits intojamiebull1:developfrom
Open
An issue with viewing a model containing surfaces without coords attribute has been fixed#251samuelduchesne wants to merge 3 commits intojamiebull1:developfrom
coords attribute has been fixed#251samuelduchesne wants to merge 3 commits intojamiebull1:developfrom
Conversation
samuelduchesne
changed the title
coords attribute has been fixed
jamiebull1
requested changes
Nov 19, 2022
Owner
jamiebull1
left a comment
jamiebull1
left a comment
There was a problem hiding this comment.
Happy to merge this, but could you please add a test in test_regression which fails without this fix first.
| if surface_type == "shading": | ||
| coords = [getcoords(s) for s in surfaces if not hasattr(s, "Surface_Type")] | ||
| shading_surfaces = list( | ||
| filter(lambda s: s.key in s.theidf.idd_index["ref2names"]["AllShadingSurfNames"], surfaces) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jamiebull1, maybe this could make it to your release. Somehow, this did not trigger CIs.