Fix: Support css variables in translation calculations#62
Open
loganwishartcraig wants to merge 1 commit intojamiebuilds:mainfrom
Open
Fix: Support css variables in translation calculations#62loganwishartcraig wants to merge 1 commit intojamiebuilds:mainfrom
loganwishartcraig wants to merge 1 commit intojamiebuilds:mainfrom
Conversation
Author
|
If backwards compatibility is a concern for whatever reason, we may also consider only wrapping in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We use css variable references in our custom tailwind theme instead of standard hardcoded values. Currently, this results in mangled values when using this library:
This PR addresses the issue my moving to
calc(...)where relevant to allow usage of css variables. Given there are no recommendations from tailwind I'm aware of warning users not to use css tokens for spacing theme values, I've just adjusted tailwindcss-animate slightly to resolve.Happy to discuss questions/concerns or close if this feels too niche a usecse.