-
Notifications
You must be signed in to change notification settings - Fork 3
Ability to tie links to a domain #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add optional domainPattern field to Link type - Update validation to support domain pattern syntax (path@domain) - Implement dynamic context menu filtering based on current tab domain - Update background.ts to filter menu items by domain regex - Update PathEditor UI with examples of domain-specific syntax - Add tab change listeners to update context menu dynamically - Maintain backward compatibility with existing configs Co-authored-by: andrewgierens <4150500+andrewgierens@users.noreply.github.com>
- Update README with domain-specific context menu documentation - Add examples and usage instructions for domain filtering - Add changelog entry for version 5.2.0 - Bump version in package.json and manifest.ts Co-authored-by: andrewgierens <4150500+andrewgierens@users.noreply.github.com>
- Extract common menu creation logic into createDefaultContextMenu helper - Update onInstalled to create filtered menu when possible - Update onStorageChange to use shared helper function - Eliminates duplicate menu creation code Co-authored-by: andrewgierens <4150500+andrewgierens@users.noreply.github.com>
When filtering context menu items by domain, headings now only appear if they have at least one non-heading link under them that matches the domain. This prevents empty headings from cluttering the context menu. Co-authored-by: andrewgierens <4150500+andrewgierens@users.noreply.github.com>
- Restructure PathEditor UI with clearer format explanation - Add explicit separator descriptions (> for name/path, @ for domain) - Use monospace font for better readability - Expand README with comprehensive format guide - Add complete configuration example with headings and multiple domains - Include important notes about escaping dots and case-insensitivity - Make distinction between required and optional components clear Co-authored-by: andrewgierens <4150500+andrewgierens@users.noreply.github.com>
Add domain-specific context menu filtering with regex patterns
| manifest_version: 3, | ||
| name: 'HappierPath', | ||
| version: '5.1.1', | ||
| version: '5.2.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
| "name": "happier-path", | ||
| "private": true, | ||
| "version": "5.1.1", | ||
| "version": "5.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
| { | ||
| "name": "happier-path", | ||
| "version": "5.1.1", | ||
| "version": "5.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
| * Clicking the same links will take you to the same routes without changing the FQDN | ||
| * This works because google.com and google.com.au share the same route structure. A traditional bookmark will also store the FQDN, which isn't useful when you have many websites that share the same route structure | ||
|
|
||
| ## Domain-Specific Context Menu (New in 5.2.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert chagnes in the readme. I'll write up some stuff in the release notes when I release
| <Typography | ||
| variant="body2" | ||
| sx={{ | ||
| mb: 1, | ||
| whiteSpace: 'pre-line', | ||
| fontFamily: 'monospace', | ||
| fontSize: 11, | ||
| }} | ||
| > | ||
| {`Format: Name>Path[@Domain] | ||
| > separates name from path (required) | ||
| @ separates path from domain pattern (optional) | ||
|
|
||
| Examples: | ||
| My Heading>0 | ||
| Admin Panel>/admin | ||
| GitHub Issues>/issues@github\\.com | ||
| Multi-site API>/api@(dev|prod)\\.example\\.com`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made the font look strange.
Ensure it looks the same as it was before.
No description provided.