Skip to content

Conversation

@jstjohn
Copy link

@jstjohn jstjohn commented Mar 15, 2017

This allows for nice things like type annotations for functions that accept a Record as well as users building dummy Record objects for testing.

For example I can now do this in pycharm and I get auto-completion on the members of Record.

import vcf


def my_record_func(record: vcf.Record):
    """
    :param record: A Record object
    :return: bool
    """
    return 'C' in record.ALT

@nathanielknight
Copy link

This looks really good; small, well explained, practical. Nice PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants