Add unit tests for previously uncovered modules#31
Merged
Conversation
Adds 102 unit tests across 9 new test_b_ files covering: NullPath, all exception classes, is_ci(), log_process_output(), string/file hash functions, metadata store/load, subprocess_run, get_app_info_py_project (PEP 621 + flit legacy), download utilities, and get_icon priority logic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_b_filesNullPath, exception classes,is_ci(),log_process_output(), hash functions, metadata store/load,subprocess_run,get_app_info_py_project(), download utilities, andget_icon()Test plan
test_b_path_exceptions.py—NullPath, all 6 exception classestest_b_ci.py—is_ci()with all env var combinationstest_b_logging.py—log_process_output()parsing, filtering, callbackstest_b_hash.py— MD5/SHA-256/SHA-512 for strings and files, known valuestest_b_metadata.py—store_metadata/load_metadataroundtrip, edge casestest_b_subprocess.py—subprocess_runreturn codes, stdout/stderr capturetest_b_app_info_pyproject.py— PEP 621, flit legacy,[tool.pyship]section, deepcopy isolationtest_b_download.py—is_within_directory,safe_extract,extract(zip/tgz/gz)test_b_get_icon.py— icon priority/fallback logic,ui_printcallback🤖 Generated with Claude Code