Skip to content

Conversation

@jamezrin
Copy link

@jamezrin jamezrin commented Jan 27, 2019

The patched version propagates exceptions created by the sockets to the main event emitter, check greim/hoxy#110

The force push is because I accidentally reverted 97993f4 which would remove the changelog entry for the previous release, so I deleted the handler myself

It works locally, but I think the way I have done this makes no sense (the submodules) so sorry for this, I wanted the commits I created to be visible, but I could've just set my repository on the package.json, but for some reason that wasn't working well when npm installing.

I don't think the PR to hoxy will get merged, it is not maintainted. So maybe the james-proxy can fork it with that fix in it?

@mitchhentges
Copy link
Member

@jamezrin thanks for the PR! I'm looking forward to having that hoxy fix be merged. Unfortunately, though that does make hoxy behave more correctly, it doesn't seem to be the cause of this crash - if it was, then this commit should've fixed it.

I checked out your branch locally, but I was still able to reproduce the bug:

  1. Check out your branch, git submodule init && git submodule update etc etc
  2. npm run clean
  3. npm run release
  4. I'm on Linux, so I invoke the AppImage created in binaries - looks like you're on Linux too, based on your screenshot
  5. Set up HTTPs proxying. This seems to be related (?)
  6. Launch Chrome (Our Firefox SSL-proxying config is incorrect I think, so it won't reproduce the bug)
  7. This is inconsistent, but I usually continuously open new tabs, go to google.com, wait for it to load, and repeat
  8. Within ~30s, james will crash

If you invoke the AppImage from the terminal, you can see the logs. On my machine in my most-recent test, it crashed with:

Error: write EPIPE
    at WriteWrap.afterWrite (net.js:833:14)

I don't recall James failing like this in the past, so I'm not sure if this is caused by:

  • A change to hoxy
  • A change to Node or Chrome,
  • Some kind of difference in james for how we're invoking hoxy

Let me know if you can reproduce the problem, and thanks again for digging into this!

@jamezrin jamezrin closed this Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants