This repository was archived by the owner on Apr 29, 2021. It is now read-only.
Fix SelectSelector to be compatible with monkey_patch #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using eventlet.monkey_patch(), it disables all the Selectors but the SelectSelector. Another thing it does is modify how the constructor handles the class methods. The way the SelectSelector handles the _select function is incompatible with that code. We should have a bound method calling the select function (as is done for the Win32) in order to fix this compatibility issue.
Collaborator
|
FYI Trollius is looking for a new maintainer: I don't maintain it anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using eventlet.monkey_patch(), it disables all the Selectors but
the SelectSelector. Another thing it does is modify how the constructor
handles the class methods.
The way the SelectSelector handles the _select function is incompatible
with that code.
We should have a bound method calling the select function (as is done
for the Win32) in order to fix this compatibility issue.