feat: Add support for 40 new languages #321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds locale data (RelativeDateTime and Ordinals) for 40 languages
as requested. This includes:
or, pa, mr, si, jv, ms, sw, ta, te, kn, ml, vi, yo, ur, gu, ro,
uz, am, ha, ig, sn, kk, el, tl, he, rw, no, fi, da, lt, sl, hr,
ca, sr, bg, ka, et, eu, gl.
- RelativeDateTime implementations for these languages currently use
English placeholder strings and will require translation.
- Ordinal data uses common defaults (empty strings or '.') and may
need specific adjustments for some languages.
- The 'no' (Norwegian) locale has been configured to use existing
Norwegian Bokmål ('nb') translations and settings.
- Unit tests have been added for the successfully integrated languages.
Important Note:
The following 6 languages are defined in the locale data but currently
will not load successfully due to not being present in the `intl`
package's default supported locale list:
jv (Javanese), yo (Yoruba), ha (Hausa), ig (Igbo), sn (Shona),
rw (Kinyarwanda).
Support for these locales will require them to be added to `intl`
or a modification to Jiffy's `verifyLocale` logic to handle
fallbacks for date symbols more gracefully.
radomir9720
reviewed
Sep 16, 2025
| @@ -1,5 +1,6 @@ | |||
| import '../utils/verify_locale.dart'; | |||
| import '../locale/relative_date_time.dart'; | |||
| import '../locale/new_locale_relative_time.dart'; | |||
There was a problem hiding this comment.
Hi @itsbalamurali. Thanks for your work, first of all.
This line looks excessive. Could you, please, remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds locale data (RelativeDateTime and Ordinals) for 40 languages as requested. This includes:
or, pa, mr, si, jv, ms, sw, ta, te, kn, ml, vi, yo, ur, gu, ro, uz, am, ha, ig, sn, kk, el, tl, he, rw, no, fi, da, lt, sl, hr, ca, sr, bg, ka, et, eu, gl.
Important Note:
The following 6 languages are defined in the locale data but currently will not load successfully due to not being present in the
intlpackage's default supported locale list:jv (Javanese), yo (Yoruba), ha (Hausa), ig (Igbo), sn (Shona), rw (Kinyarwanda).
Support for these locales will require them to be added to
intlor a modification to Jiffy'sverifyLocalelogic to handle fallbacks for date symbols more gracefully.Issue Reference
Fixes #
Types of changes
Screenshots
If applicable, add screenshots to help explain your problem.
Checklist
./binfolderAdditional Information