Fix off-by-20 in KK studio toggles#11
Open
websitemonitorer wants to merge 1 commit intojalil49:MoreAccessories_Overhaulfrom
Open
Fix off-by-20 in KK studio toggles#11websitemonitorer wants to merge 1 commit intojalil49:MoreAccessories_Overhaulfrom
websitemonitorer wants to merge 1 commit intojalil49:MoreAccessories_Overhaulfrom
Conversation
Author
|
Seeing my issue #13 and my other PR, maybe it would be safer to backport these modifications to the version of the plugin before the last commit |
Contributor
|
I released a safe version with this PR merged at https://github.com/ManlyMarco/MoreAccessories/releases/tag/2.0.21.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the action of showing/hiding an accessory itself worked, the white-green toggles of additional accessories reflected the state of the ones 20 spaces above
I have also moved all uses of i+20 to i1 since it was already there, just use show[i+20] if you don't like it