Add graceful shutdown to Dali with configurable client disconnect wait #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Kubernetes helm chart removal, unordered pod termination causes Dali to shutdown before clients, leaving them stalled attempting reconnection until forcibly terminated by k8s grace period.
Changes
Core implementation (
dali/base/dasess.cpp):waitForClientsToDisconnect(unsigned timeoutMs)toCCovenSessionManagerCDaliSessionServer::suspend()to wait during shutdown initiationshutdownGracePeriodconfig (default: 60s, max: 1 day)Configuration:
Behavior:
suspend()waits for client count to reach zero or timeoutstop()proceeds with normal shutdown sequenceThread safety: Uses existing
CHECKEDCRITICALBLOCK(sessmanagersect)for client lookup access.Documentation: Added
dali/GRACEFUL_SHUTDOWN.mdwith configuration examples, behavior details, and Kubernetes integration notes.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.