Skip to content

Conversation

@volosied
Copy link
Member

This should allow us to finally publish this jar.

For #275

Copy link
Member

@pnicolucci pnicolucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to publish this as part of the Jakarta Tags API? We forked the generator code to get it to work with our existing project. I'm not sure the Tags API is the correct place to maintain the fork for everyone else to use. Are we going to be fixing bugs as well?

Do we publish it anyplace internally now or are we just using it at build time to generate the docs we want for the our API?

We should revisit: #195 and the associated PR where we did the initial work and discuss further.

@volosied
Copy link
Member Author

In my opinion, it should have been published years go (as is a pom dependency), but never was. You originanally also said this in the following comment:

Looking at this closer I don't think we'll be able to depend on something that is not available out on maven central so we'll need to publish the tlddoc artifacts that we're using within the implementation. If someone tells me I'm incorrect here then that would be fine but to the best of my knowledge, we won't be able to just have it locally to this repo without publishing it.

I don't believe anyone else will be using this TagDoc library (other than us), but if maintaining does become an issue, we can perhaps a create a specific repository for it.

For now, at least, I would just like to one version published for the moment. It's would also be under different coordinates not strictly associated with Tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants