Using directory-maven-plugin to initialize legal.source.folder property#285
Open
senivam wants to merge 2 commits intojakartaee:mainfrom
Open
Using directory-maven-plugin to initialize legal.source.folder property#285senivam wants to merge 2 commits intojakartaee:mainfrom
senivam wants to merge 2 commits intojakartaee:mainfrom
Conversation
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
Contributor
Author
|
@bshannon - required change implemented, could you please take a look? |
bshannon
approved these changes
Jan 7, 2020
Contributor
bshannon
left a comment
There was a problem hiding this comment.
That probably works, but I've done it in two steps. First, use the plugin to define a more general but descriptive property, then use that property in other configuration, or use to define other properties.
<execution>
<id>directories</id>
<goals>
<goal>highest-basedir</goal>
</goals>
<phase>initialize</phase>
<configuration>
<property>main.basedir</property>
</configuration>
</execution>
Also, I'm not sure execution-root is really what you want if someone runs mvn from a lower level directory.
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
Contributor
Author
|
yes, you are right, the target for plugin shall be adjusted in order to work from the lower lever directory. However in order to work, the api's parent shall be adjusted as well. So, I've done required modifications to allow property initialization from any folder. |
bshannon
approved these changes
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improving #284 by using plugin to initialize property instead of internal maven property
Signed-off-by: Maxim Nesen maxim.nesen@oracle.com