Fix failing tests since changes in rendering behavior scripts #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnriem
approved these changes
Aug 19, 2025
Member
Author
|
@arjantijms in the future please only merge PR when it targets a release branch, or leave merging up to the PR creator. This PR targeted "fix flaky tests" branch which was in turn not merged into a release branch yet. It should have been merged first. Because the "fix flaky tests" branch has been completed in a different branch by someone else, that branch is closed off. But as the current PR is already merged into there and thus never ended up in a release branch, I basically have to redo the current branch/PR instead of simply rebasing the branch/PR. That wouldn't have been necessary if it wasn't merged. |
Member
Author
|
Superseded by #2055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1590 for eclipse-ee4j/mojarra#5601
Ran entire TCK. Only one test failed and the particular test explicitly checked presence of onchange attribute instead of actual outcome of the behavior. So improved it and added two more use cases.
Rest of TCK all green for eclipse-ee4j/mojarra#5601