Sourcery Starbot ⭐ refactored jaekookang/p2fa_py3

[SourceryAI]

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/p2fa_py3 master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[SourceryAI]

Function getopt2 refactored with the following changes:

• Simplify sequence comparison (simplify-len-comparison)

[SourceryAI]

Function prep_wav refactored with the following changes:

• Hoist conditional out of nested conditional (hoist-if-from-if)

[SourceryAI]

Function write_input_mlf refactored with the following changes:

• Use with when opening file to ensure closure (ensure-file-closed)

[SourceryAI]

Function write_text_grid refactored with the following changes:

• Use with when opening file to ensure closure (ensure-file-closed)

[SourceryAI]

Function prep_scp refactored with the following changes:

• Use with when opening file to ensure closure (ensure-file-closed)

[SourceryAI]

Function viterbi refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.35%.

Quality metrics	Before	After	Change
Complexity	11.35 🙂	11.42 🙂	0.07 👎
Method Length	118.59 🙂	117.59 🙂	-1.00 👍
Working memory	15.83 ⛔	15.89 ⛔	0.06 👎
Quality	43.42% 😞	43.07% 😞	-0.35% 👎

Other metrics	Before	After	Change
Lines	434	425	-9

Changed files	Quality Before	Quality After	Quality Change
bin/p2fa	76.45% ⭐	76.62% ⭐	0.17% 👍
p2fa/align.py	41.51% 😞	41.09% 😞	-0.42% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
p2fa/align.py	align	17 🙂	323 ⛔	25 ⛔	22.38% ⛔	Try splitting into smaller methods. Extract out complex expressions
p2fa/align.py	prep_mlf	20 😞	223 ⛔	23 ⛔	25.12% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
p2fa/align.py	write_text_grid	14 🙂	516 ⛔	11 😞	35.03% 😞	Try splitting into smaller methods. Extract out complex expressions
p2fa/align.py	read_aligned_mlf	9 🙂	196 😞	17 ⛔	39.94% 😞	Try splitting into smaller methods. Extract out complex expressions
p2fa/align.py	prep_wav	12 🙂	178 😞	14 😞	42.09% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.