Fixes and updates for SimpleDashboard #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated Layout.py to allow for common ETFs (like SPY, QQQ) which have missing or non-numeric fields updated stock ticker error messages to be more informative added ticker to getCandlestick to allow for the plot legend fixed table label for shares outstanding, was a duplicate EPS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues with SimpleDashboard, the candlestick chart was missing the moving average lines, some common tickers wouldn't work (like SPY or QQQ) and the SP500 .csv file wouldn't load (had a bad UTF-8 char). These are my updates:
fixed missing moving average plots on candlestick chart
updated Layout.py to allow for common ETFs (like SPY, QQQ) which have missing or non-numeric fields
updated stock ticker error messages to be more informative
added ticker to getCandlestick() to allow for the plot legend
fixed table label for shares outstanding, was a duplicate EPS
re-saved SP500StockList to fix UTF-8 encoding error, no content changes
Cheers,
Kevin