chore: code cleanup + extension conflict troubleshooting#260
Merged
Conversation
Owner
jackwener
commented
Mar 22, 2026
jackwener
commented
- Cleanup: removed redundant double-retry, stale comments, verbose logging
- Added extension conflict hint to attach-failed error messages
- Added troubleshooting for extension conflicts (youmind, etc.) to README
- Version 1.2.6
Cleanup: - Remove redundant double-retry in resolveTabId (was retrying data: URI with the same data: URI) - Fix stale comment (30s → 120s idle timeout) - Remove verbose debug logging in resolveTabId - Built extension is now smaller (16.66kB vs 17.18kB) Extension conflict: - Add hint to attach-failed error when chrome-extension:// URL is detected - Add troubleshooting entry for extension conflicts (e.g. youmind, New Tab Override) to both README.md and README.zh-CN.md Ref: #249
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.