fix: harden resolveTabId against New Tab Override interception#255
Merged
fix: harden resolveTabId against New Tab Override interception#255
Conversation
resolveTabId's reuseTab path now verifies the URL is actually debuggable after navigating to about:blank. If a New Tab Override extension intercepts it (setting it back to chrome-extension://), falls back to a data: URI, then creates a fresh tab as last resort. This fixes the persistent 'attach failed: Cannot access chrome-extension://' error for users with New Tab Override extensions installed. Ref: #249
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes persistent
attach failed: Cannot access chrome-extension://error for users with New Tab Override extensions.Problem
resolveTabId's reuseTab path navigated toabout:blankand waited 200ms, but New Tab Override extensions can interceptabout:blankand replace it withchrome-extension://, causing CDP attach to fail.Fix
After navigating to
about:blank, verify the URL is actually debuggable. If intercepted:data:text/htmlURI (can't be intercepted by New Tab Override)Ref: #249